Re: FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile

From: Colin Percival (cperciva_at_freebsd.org)
Date: 04/05/05

  • Next message: Ian G: "Secunia / Firefox Javascript "Arbitrary Memory Exposure" test" 
    Date: Tue, 05 Apr 2005 01:40:03 -0700
To: Uwe Doering <gemini@geminix.org>

    Uwe Doering wrote:
    > + vnode_pager_setsize(vp, 0);
    >
    > I wonder, isn't the variable 'vp' actually supposed to be 'ovp' in the
    > added line? Technically they are identical. 'ovp' is assigned from
    > 'vp' once in the variable definition section at the start of the function.
    >
    > However, using 'vp' when calling vnode_pager_setsize() looks a little
    > odd given that anywhere else in this function, including another call to
    > vnode_pager_setsize(), the variable 'ovp' is used instead of 'vp'.

    I agree that it looks a bit odd; a few people have pointed this out to us
    (but none of them before it was committed into the CVS tree). That said,
    it doesn't seem to matter, so I'm not going to go back and change the patch
    now.

    Colin Percival
    _______________________________________________
    freebsd-security@freebsd.org mailing list
    http://lists.freebsd.org/mailman/listinfo/freebsd-security
    To unsubscribe, send any mail to "freebsd-security-unsubscribe@freebsd.org"

  • Next message: Ian G: "Secunia / Firefox Javascript "Arbitrary Memory Exposure" test"